Skip to content

build: increase mac signature verification timeout - #317208

Merged
Robo (deepak1556) merged 1 commit into
mainfrom
brchen/macos-signature-verify-timeout
May 19, 2026
Merged

Robo (deepak1556) merged 1 commit into
mainfrom
brchen/macos-signature-verify-timeout

Conversation

@bryanchen-d

Copy link
Copy Markdown
Collaborator

Summary

  • increase macOS signature verification timeout from 3 minutes to 5 minutes for arch builds
  • increase the universal macOS signature verification timeout from 2 minutes to 5 minutes

Details

Build 440250 failed in the macOS (X64) Verify signature step because the signed app startup smoke check completed just as the Azure Pipelines task hit its timeout. The codesign output showed a valid Developer ID signature and a stapled notarization ticket, and the app eventually wrote startup timers, so this gives the smoke check more room without changing the verification behavior.

Validation

  • npm run precommit

Copilot AI review requested due to automatic review settings May 18, 2026 23:44
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Ladislau Szomoru (@lszomoru)

Matched files:

  • build/azure-pipelines/darwin/product-build-darwin-universal.yml
  • build/azure-pipelines/darwin/steps/product-build-darwin-compile.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Increases the Azure Pipelines task timeout for the macOS "Verify signature" step to reduce flaky failures where the signed app startup smoke check completes near the prior timeout boundary.

Changes:

  • Bump per-arch macOS verify-signature timeout from 3 to 5 minutes.
  • Bump universal macOS verify-signature timeout from 2 to 5 minutes.
Show a summary per file
File Description
build/azure-pipelines/darwin/steps/product-build-darwin-compile.yml Increases timeoutInMinutes from 3 to 5 for the arch build verify-signature step.
build/azure-pipelines/darwin/product-build-darwin-universal.yml Increases timeoutInMinutes from 2 to 5 for the universal verify-signature step.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@deepak1556
Robo (deepak1556) merged commit 2d90e41 into main May 19, 2026
29 checks passed
@deepak1556
Robo (deepak1556) deleted the brchen/macos-signature-verify-timeout branch May 19, 2026 00:08
@deepak1556

Copy link
Copy Markdown
Collaborator

Thanks! I was bumping this already in #316661, x64 runs via rosetta hence the slowdown.

@vs-code-engineering vs-code-engineering Bot added this to the 1.122.0 milestone May 19, 2026
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Jul 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants